feat: [OI-249] spinner on idps fetch #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mmoio
commented
Nov 26, 2024
•
mmoio
commented
- button loading status while idps list is not populated
- separete api functions
- separet login data hook
- separetd login buttons
- unit test
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
9fe2e4d
to
7afb552
Compare
mmoio
requested a deployment
to
prod/eu-south-1
GitHub Actions
Waiting
mmoio
requested a deployment
to
prod/eu-central-1
GitHub Actions
Waiting
- separete api functions - separet login data hook - separetd login buttons - unit test
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
7afb552
to
7d7ec3a
Compare
|
I am not particularly convinced about loading the spinner when the page loads. This causes the user to see the loading every time they land on the page when in fact the time it takes the user to click on the “Entra con SPID” button can be used for background loading. |
|
as a secondary issue, when a client_id is not present in GET I see in console this message, maybe we should think about something more clear
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.